feat: adds ability to provide a OSLog instance via the Config.logger property #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
May 30, 2024
| /// Additional HTTP headers to be set on the request | ||
| public var headers: [String: String] = [:] | ||
| /// Transform function to allow dynamically configuring the headers on each API request. | ||
| public var headerTransform: HeaderTransform = { $0 } | ||
| /// An initial value for the last-event-id header to be sent on the initial request | ||
| public var lastEventId: String = "" |
There was a problem hiding this comment.
For reviewers: just reordering a bit for something closer to alphabetization.
keelerm84
approved these changes
May 31, 2024
tanderson-ld
added a commit
that referenced
this pull request
May 31, 2024
🤖 I have created a release *beep* *boop* --- ## [3.3.0](3.2.0...3.3.0) (2024-05-31) ### Features * adds ability to provide a OSLog instance via the Config.logger property ([c10ec29](c10ec29)) * adds ability to provide a OSLog instance via the Config.logger property ([#78](#78)) ([2220929](2220929)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
SC-245493
Describe the solution you've provided
Added Config.logger property that is only available on platforms supporting OSLog.
Describe alternatives you've considered
Creating a LD specific protocol for logging and exposing that. Customer's would then have to implement an adapter for this. This was rejected as adding more logging flavors to the ecosystem is probably a worse outcome.
Additional context
Logging was previously a no-op on Linux and Windows, and that continues to be the case.